nvmeof: adding namespace masking calls#6241
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the NVMe-oF gateway gRPC client wrapper (GatewayRpcClient) with namespace-masking helpers to manage per-namespace host access and namespace auto-visibility, as preparation for future external-client support.
Changes:
- Add
NameSpaceAddHost()to grant a host NQN access to a specific namespace. - Add
NameSpaceRemoveHost()to revoke a host NQN access from a specific namespace. - Add
NameSpaceChangeAutoVisibility()to toggle namespaceauto-visiblebehavior.
gadididi
force-pushed
the
nvmeof/add_ns_masking
branch
2 times, most recently
from
0560f96 to
6fe19f2
Compare
gadididi
force-pushed
the
nvmeof/add_ns_masking
branch
from
6fe19f2 to
f884b08
Compare
gadididi
force-pushed
the
nvmeof/add_ns_masking
branch
from
f884b08 to
90b2299
Compare
nixpanic
approved these changes
Apr 22, 2026
Member
nixpanic
left a comment
nixpanic
left a comment
There was a problem hiding this comment.
Looks reasonable to me. There is no use of the new functions yet, so no need for e2e testing either.
Madhu-1
approved these changes
Apr 23, 2026
Contributor
|
Deprecation notice: This pull request comes from a fork and was queued with |
Contributor
Merge Queue Status
This pull request spent 37 minutes 11 seconds in the queue, including 36 minutes 52 seconds running CI. Required conditions to merge
|
added 3 grpc calls: 1. `NameSpaceAddHost()` - which is adding hostNQN for specific namespace (by given ns-id). 2. `NameSpaceRemoveHost()` - which is removing hostNQN for specific namespace (by given ns-id). 3. `NameSpaceChangeAutoVisibility()` - for adding host into specific namespace the namespace should be first non-auto-visible. So this called is added too. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
ceph-csi-bot
force-pushed
the
nvmeof/add_ns_masking
branch
from
90b2299 to
54dfc2f
Compare
Contributor
Author
|
@mergify rebase |
Contributor
☑️ Nothing to do, the required conditions are not metDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added 3 grpc calls:
NameSpaceAddHost()- which is adding hostNQN for specific namespace (by given ns-id).NameSpaceRemoveHost()- which is removing hostNQN for specific namespace (by given ns-id).NameSpaceChangeAutoVisibility()- for adding host into specific namespace the namespace should be first non-auto-visible. So this called is added too.This PR is a preparatory step for a future PR that will introduce using of namespace masking feature for external clients.
more details about the external client feature is here: #6240
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)